[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Automatic LyricExtenders (issue 313240043 by address@hidden)
From: |
dak |
Subject: |
Re: Automatic LyricExtenders (issue 313240043 by address@hidden) |
Date: |
Wed, 18 Jan 2017 00:28:16 -0800 |
https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy
File lily/parser.yy (right):
https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy#newcode3107
lily/parser.yy:3107: $$ = $1;
That looks like strange fallback behavior. EXTENDER likely has a value
of SCM_UNSPECIFIED (at least I think that is the default for tokens
without attached value). Can the containing expression deal with that?
If it can, it would make more sense to explicitly use SCM_UNSPECIFIED,
or otherwise whatever other value is accepted by those using the
containing syntactical expression.
https://codereview.appspot.com/313240043/