[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Update EventChord to include a ChordSemantics event entry which captures
From: |
pkx166h |
Subject: |
Update EventChord to include a ChordSemantics event entry which captures input semantic information… (issue 332090043 by address@hidden) |
Date: |
Thu, 02 Nov 2017 09:37:29 -0700 |
Charles I posted a comment on the LilyPond Tracker issue that was
created for this.
https://sourceforge.net/p/testlilyissues/issues/5224/
I'll past it here:
I don't understand the reason for the dozens of files that are changed
in your patch. Why you also have added a 'README.md' file (we don't tend
to do that), the documentation files that have changed seem to contain
diffs that have nothing at all to do with the description of your patch
at all.
I wonder if you have made a mistake here and not rebased your changes
against current master or are basing it off some other branch?
I cannot test the patch as it is at the moment. Sorry.
https://codereview.appspot.com/332090043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Update EventChord to include a ChordSemantics event entry which captures input semantic information… (issue 332090043 by address@hidden),
pkx166h <=