Re: Fix security problem in lilypond-invoke-editor (issue 336240043 by address@hidden)

[knupero]

https://codereview.appspot.com/336240043/diff/40001/scripts/lilypond-invoke-editor.scm
File scripts/lilypond-invoke-editor.scm (right):

https://codereview.appspot.com/336240043/diff/40001/scripts/lilypond-invoke-editor.scm#newcode1
scripts/lilypond-invoke-editor.scm:1:
#!/home/knut/sources/lilybuilt/share/lilypond/bin/guile -s
On 2017/11/24 12:57:21, dak wrote:
> This line is not going to work.

Arrgh! Obvious.

https://codereview.appspot.com/336240043/diff/40001/scripts/lilypond-invoke-editor.scm#newcode110
scripts/lilypond-invoke-editor.scm:110: (define (run-editor uri)
On 2017/11/24 12:57:21, dak wrote:
> I think editor.scm is used elsewhere so its basic API
(get-editor-command)
> should be made to work.

Well, I took it from editor.scm and nuked (primitive-eval '(use-modules
(scm editor))) below. The problem was that we need one string per
argument if system* (or execlp) is used.

https://codereview.appspot.com/336240043/diff/40001/scripts/lilypond-invoke-editor.scm#newcode172
scripts/lilypond-invoke-editor.scm:172: (run-editor (car files))))
Does anybody know why the original authors used (strip-framework-path
"LD_LIBRARY_PATH") here?

https://codereview.appspot.com/336240043/