[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Prob::equal_p: discard "origin" property (issue 363740043 by address@hid
From: |
thomasmorley65 |
Subject: |
Prob::equal_p: discard "origin" property (issue 363740043 by address@hidden) |
Date: |
Fri, 27 Jul 2018 02:32:55 -0700 |
Can't review C++.
But from a little testing:
http://lilypond.1069038.n5.nabble.com/Iterating-music-for-voiceOne-Checking-with-equal-td215135.html#a215158
it works as wished.
A question not directly related to your patch:
https://codereview.appspot.com/363740043/diff/1/lily/prob.cc
File lily/prob.cc (right):
https://codereview.appspot.com/363740043/diff/1/lily/prob.cc#newcode36
lily/prob.cc:36: equality; e.g., that two probs are equal iff they can
be
Is this comment correct?
Shouldn't it be
"...iff they _can't_ be distinguished..."
Please ignore, if it's a stupid remark, caused by my lack of
knowledge...
https://codereview.appspot.com/363740043/
- Prob::equal_p: discard "origin" property (issue 363740043 by address@hidden),
thomasmorley65 <=