Re: Improve markup->string (issue 347000043 by address@hidden)

[thomasmorley65]

On 2018/11/10 12:53:18, dak wrote:
> I wonder whether it might be reasonable to just have all markup
commands with a
> last argument of markup? produce their last (recursively treated)
argument as
> default, and possibly all markup list commands with a last argument of
> markup-list? similarly produce their last argument?  That leaves fewer
commands
> to cater for and would also make some user-defined commands work
reasonably
> well.

I think I do not fully understand what you mean.

'all-relevant-markup-commands' tries to get all markup-(list-)commands
where 'markup->string' may return reasonable output.
Currently by looking whether 'cheap-markup?' or 'markup-list?' are
somewhere in their predicates.
This could be changed to look whether those are last in predicates.
Would simplify the coding and 'markup->string' only works in this case
anyway. (At least following a comment there.)

So far I understood, at least I hope so.
I have some other simplifications in mind, will upload with next patch.
Though, the amount of caught markup-(list-)commands is the same for both
codings.

But what do you mean with "produce their last (recursively treated)
argument as default"
Could you elaborate a bit?



https://codereview.appspot.com/347000043/