|
From: | dak |
Subject: | Re: New feature: automatically invert chords or drop/rise chord notes (issue 365840043 by address@hidden) |
Date: | Wed, 23 Jan 2019 14:30:24 -0800 |
https://codereview.appspot.com/365840043/diff/80001/scm/modal-transforms.scm File scm/modal-transforms.scm (right): https://codereview.appspot.com/365840043/diff/80001/scm/modal-transforms.scm#newcode324 scm/modal-transforms.scm:324: (sorted (sort pitches ly:pitch<?))) Shouldn't you consider preexisting octavation for sorting the pitches? https://codereview.appspot.com/365840043/diff/80001/scm/modal-transforms.scm#newcode331 scm/modal-transforms.scm:331: (ly:music-set-property! e 'pitch p)) That looks like a mess. You juggle the pitches of the notes without changing the notes themselves. Won't this break the assignment of articulations and octavation to the notes/pitches? Don't you rather intend to sort the _notes_? https://codereview.appspot.com/365840043/diff/80001/scm/modal-transforms.scm#newcode337 scm/modal-transforms.scm:337: (list-set! elts count-from list-set! here is unnecessary since ly:music-transpose modifies its argument. https://codereview.appspot.com/365840043/
[Prev in Thread] | Current Thread | [Next in Thread] |