[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new
From: |
Masamichi Hosoda |
Subject: |
Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?' |
Date: |
Thu, 24 Jan 2019 23:44:55 +0900 (JST) |
>>> This is a gs 9.26 issue and I cannot see how this might be related to what
>>> we have hit here, so maybe Hosoda-san will be abel to figure why make check
>>> is breaking without extractpdfmark installed.
>>
>> If I understand correctly, this patch solves the error.
>>
>> ```
>> --- a/scripts/build/output-distance.py
>> +++ b/scripts/build/output-distance.py
>> @@ -652,7 +652,7 @@ class SignatureFileLink (FileLink):
>> data_option = ''
>> if options.local_data_dir:
>> data_option =
>> ('-slilypond-datadir=%s/share/lilypond/current '
>> - % dir)
>> + % (cur_dir + '/' + dir))
>>
>
> Is dir guaranteed to be a relative path?
It seems that there is no guarantee.
But, `make check` invokes `output-distance` with relative paths.
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=GNUmakefile.in;h=da1f6f64e088756e07d20f8e1603ccc3a102053e;hb=HEAD#l340
Therefore, `dir` is also a relative path.
There seems to be no place invoking `output-distance` other than that.
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', (continued)
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Karlin High, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Valentin Villenave, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', David Kastrup, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', James Lowe, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Valentin Villenave, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', David Kastrup, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Masamichi Hosoda, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', David Kastrup, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Knut Petersen, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', David Kastrup, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?',
Masamichi Hosoda <=
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', David Kastrup, 2019/01/24
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Masamichi Hosoda, 2019/01/25
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', Thomas Morley, 2019/01/23
- Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?', John Mandereau, 2019/01/20