|
| From: | dak |
| Subject: | Re: Issue 5485: avoid -Wsequence-point warning (issue 351880043 by address@hidden) |
| Date: | Thu, 28 Feb 2019 05:19:11 -0800 |
https://codereview.appspot.com/351880043/diff/20001/lily/page-turn-page-breaking.cc
File lily/page-turn-page-breaking.cc (right):
https://codereview.appspot.com/351880043/diff/20001/lily/page-turn-page-breaking.cc#newcode37
lily/page-turn-page-breaking.cc:37: bool page_breakable = scm_is_symbol
(g->get_property ("page-break-permission"));
This always looks up three properties. The previous code likely stopped
after the first. Lookups are actually expensive.
https://codereview.appspot.com/351880043/
| [Prev in Thread] | Current Thread | [Next in Thread] |