[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by
|
From: |
john . mandereau |
|
Subject: |
Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by address@hidden) |
|
Date: |
Tue, 12 Mar 2019 14:56:32 -0700 |
This looks good to me, except a phrasing nitpick.
https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi#newcode2217
Documentation/contributor/source-code.itexi:2217: @warning{Never push
directly to master always push to staging. See
It sounds to me that something is missing between "master" and "always",
at least some punctuation like a comma or a semi-colon.
https://codereview.appspot.com/566540043/