Re: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by address@hidden)

[pkxgnugitcl]

Reviewers: lemzwerg, anthoneyhughes88,

Message:
Thanks Werner


https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185
Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file
allows English note names to be used.
On 2019/07/01 02:54:33, lemzwerg wrote:
> Please use `@file' for file names.

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode257
Documentation/notation/world.itely:257: are defined in either
@code{hel-arabic} or @file{arabic.ly} files and
On 2019/07/01 02:54:33, lemzwerg wrote:
> @file{hel-arabic.ly} ?

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode262
Documentation/notation/world.itely:262: music. Arabic maqams only allow
for limited modulations, due to the
On 2019/07/01 02:54:33, lemzwerg wrote:
> Please use two spaces after a full stop that ends a sentence.

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode266
Documentation/notation/world.itely:266: of music;
On 2019/07/01 02:54:33, lemzwerg wrote:
> Instead of a semicolon I think it's better to use either a full stop
or a colon.

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode281
Documentation/notation/world.itely:281: below (e.g. @notation{bayati},
@notation{hussaini}, @notation{saba}, and
On 2019/07/01 02:54:33, lemzwerg wrote:
> e.g.,

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode282
Documentation/notation/world.itely:282: @notation{ushaq} can be
indicated in the same way.  These are all
On 2019/07/01 02:54:33, lemzwerg wrote:
> @notation{ushaq})

Done.

https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode290
Documentation/notation/world.itely:290: parenthesis for those that are
modulations of their base maqam.
On 2019/07/01 02:54:33, lemzwerg wrote:
> parentheses

Done.

Description:
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly

Using information provided
by Hassan Elfatihi this
section now includes
references to the
significantly updated
hel-arabic.ly file.

Other fixes include making
sure we follow CG policy with
@seealso ordering as well
as line length and some
@notation{} syntax additions.

Please review this at https://codereview.appspot.com/560790043/

Affected files (+82, -50 lines):
  M Documentation/notation/world.itely