Re: Issue 5621: Improve rehearsal mark position at beginning of staff. (issue 553290043 by address@hidden)

[lemzwerg]

Reviewers: Dan Eble,

Message:
> I see many cases in the regression tests that this
> change fails to improve, for example:

> In input/regression/rehearsal-mark-formatters.ly,
> the new position of the "H" mark is an improvement,
> but the new position of the "CC" mark isn't.

Yes.  This is unavoidable because the horizontal offset is statically
set to a fixed value optimized for a single rehearsal letter or a
double-digit rehearsal number (using LilyPond's default font settings).
To automatically improve the positioning of the "CC" mark, a dynamic
solution would be necessary which I'm not able to implement.  What I
could do is to update this regression test to adjust the position once,
but I think this is not a good idea.

> In input/regression/rehearsal-mark-align-priority.ly,
> the marks over the F clef didn't need to be shifted,
> and the mark over the G clef didn't benefit from being
> shifted.

Yes.  IMHO, there is nothing to 'improve'.  If you change the alignment
order of break elements you also have to adjust the anchors if
necessary.  The original value 'RIGHT' for aligning something to a
change clef is as unnatural as my proposed value 2.


Description:
Issue 5621: Improve rehearsal mark position at beginning of staff.

This tiny change positions the rehearsal mark farther to the left at the
beginning of a staff, thus no longer horizontally overlapping with the
clef
(which caused LilyPond to move the rehearsal mark up to avoid a
collision).

Please review this at https://codereview.appspot.com/553290043/

Affected files (+1, -1 lines):
  M scm/define-grobs.scm


Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index  
5e29d9f8456d96644ad3dac9b98b868d2462e003..f86a8559b1bed376e30ac72d174b2e9f0ff14275  
100644
--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -551,7 +551,7 @@
      . (
         (avoid-slur . inside)
          
(break-align-anchor . ,ly:break-aligned-interface::calc-extent-aligned-anchor)
-        (break-align-anchor-alignment . ,RIGHT)
+        (break-align-anchor-alignment . 2)
         (break-align-symbol . clef)
         (break-visibility . ,begin-of-line-visible)
          
(extra-spacing-height . ,pure-from-neighbor-interface::extra-spacing-height-at-beginning-of-line)