Re: Chord names clean-up; no more Banter, exceptionsPartial or \powerChords

[David Kastrup]

Flaming Hakama by Elaine <address@hidden> writes:

>> ---------- Forwarded message ----------
>> From: address@hidden
>> To: address@hidden
>> Cc: address@hidden, address@hidden
>> Date: Tue, 07 Jan 2020 14:06:51 -0800
>> Subject: Re: Chord names clean-up; no more Banter, exceptionsPartial or
>> \powerChords. (issue 363880043 by address@hidden)
>>
>> https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py
>> File python/convertrules.py (right):
>>
>>
>> https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py#newcode3980
>> python/convertrules.py:3980
>> <https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py#newcode3980python/convertrules.py:3980>:
>> if re.search
>> (r"#[banter|jazz]-chord-names", str):
>> I have no idea what this regexp is actually supposed to be/do.  But it
>> needs to get fixed.  Any idea what this should be instead?
>>
>> As it is, it matches a # followed by one of the letters abejntrz| and
>> then -chord-names .  This is very likely not what is intended here.
>>
>> https://codereview.appspot.com/363880043/
>>
>
> My guess as to the intention is that it should match either
> "#banter-chord-names" or "#jazz-chord-names".
>
> Although, it is unclear why those strings are important.
>
> Seems like they just mistakenly used square brackets instead of parenthesis
> for grouping in the regular expression.

Ah yes, that makes sense.  Of course, those patterns are garbage as well
since the correct names would be banter-chordnames and jazz-chordnames.
But at least it appears like we are getting somewhere.

-- 
David Kastrup