[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5695: reduce dynamic casting (issue 575530107 by address@hidde
|
From: |
dak |
|
Subject: |
Re: Issue 5695: reduce dynamic casting (issue 575530107 by address@hidden) |
|
Date: |
Sat, 25 Jan 2020 09:37:10 -0800 |
https://codereview.appspot.com/575530107/diff/581530050/lily/spaceable-grob.cc
File lily/spaceable-grob.cc (right):
https://codereview.appspot.com/575530107/diff/581530050/lily/spaceable-grob.cc#newcode92
lily/spaceable-grob.cc:92: break;
That looks still too complicated. Just do return *next_spring; here, no
need to break out of the loop. Then you don't need the variable spring
at all (since it will be 0 if the loop exits regularly) and can hijack
its name for the more cumbersome next_spring. And the final return can
just be return Spring ();
Oh, and the programming_error can be called unconditionally then.
https://codereview.appspot.com/575530107/