|
From: | nine . fierce . ballads |
Subject: | Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden) |
Date: | Mon, 27 Jan 2020 05:39:30 -0800 |
https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily_parser *parser); Changing Input& to Input* is more than cosmetic. Input& requires an object, but Input* admits a nullptr. I'm concerned that I don't see that any checks have been added before the pointer is dereferenced. https://codereview.appspot.com/577410045/
[Prev in Thread] | Current Thread | [Next in Thread] |