[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by add
From: |
hanwenn |
Subject: |
Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden) |
Date: |
Fri, 31 Jan 2020 10:33:09 -0800 |
On 2020/01/31 18:22:47, Dan Eble wrote:
> On 2020/01/31 17:52:45, hanwenn wrote:
> > you can do a local alias
> >
> > vector<> &v = *vec;
> >
> > to aid readability.
>
> The more I think about banning non-const reference parameters, the
more I'm
> against it. Google's coding standards may work for them, but their
rationale*
> for this one is weak. How can we resolve this disagreement quickly?
Do you
> simply have the final say as the project founder?
Can we have this discussion on a thread separate from this code review?
I want this code to go in.
https://codereview.appspot.com/577410045/
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), (continued)
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), benko . pal, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), hanwenn, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), nine . fierce . ballads, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), hanwenn, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), nine . fierce . ballads, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden),
hanwenn <=
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), Carl . D . Sorensen, 2020/01/31