[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-developers] [BUG/RFC] linphonec 2.0.1 : friend list manage
From: |
strk |
Subject: |
Re: [Linphone-developers] [BUG/RFC] linphonec 2.0.1 : friend list management |
Date: |
Mon, 3 Mar 2008 18:12:48 +0100 |
On Mon, Mar 03, 2008 at 05:38:54PM +0100, Andreas Pretzsch wrote:
> Looking at the code, the friends are inserted into the lists with
> sorting. Sorting is based on the username, beside other factors:
> lc->friends=ms_list_insert_sorted(lc->friends,(void*)lf,friend_compare);
>
> The comparison key username, in this case two times "apr", leads to such
> behaviour.
>
> For now, I locally replaced the insert call with
> lc->friends=ms_list_append(lc->friends,(void *)lf);
>
> I did not check if anything breaks because of this.
>
> Simon, I'd suggest you should think about wheter
> - Sorting is sensible here at all
> - Modification of the sort criteria
I personally find 'friend call #' uncomfortable.
Added that code myself but was too lazy.
A nice way would be assigning an alias to the friends,
or allow to use a regex for matching.
--strk;