[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-developers] Request to merge 3 patches about oRTP library
From: |
BOITEUX, Frederic |
Subject: |
Re: [Linphone-developers] Request to merge 3 patches about oRTP library |
Date: |
Mon, 21 Mar 2016 08:12:13 +0000 |
Hi Gautier,
Thanks for the info. I understand your hesitation about the third, big patch.
If you finally find another way to tie a trace to its session, I'd be glad to
use it.
With regards,
Fred.
-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Gautier Pelloux-Prayer
Envoyé : vendredi 18 mars 2016 10:20
À : address@hidden
Objet : Re: [Linphone-developers] Request to merge 3 patches about oRTP library
Hi Frederic,
I integrated both first and second patch, however I did not include the last
one yet; we need to discuss how we'd like to handle logs; having a session
parameter everywhere to log only seems a bit overkill, and it won't fix issues
on upper levels (ms2 should log by mediastream, linphone by linphonecore,
etc.). There was already an attempt so use session for logging but I believed
we never merged it because of unresolved problems with it.
Cheers,
Gautier Pelloux-Prayer
Software Engineer @ Belledonne Communications
> On 15 Mar 2016, at 16:44, BOITEUX, Frederic <address@hidden> wrote:
>
> Hello,
>
> I’ve built theses patches on top of latest oRTP git clone.
>
> The first and second patches are about compiling test programs along with
> oRTP library, it allows these compilations, and fix a trivial warning in one
> of test program.
>
> The third patch is much bigger (compacted with xz) : il extend logging system
> to add RTP session information, and use this extension wherever possible
> through the library. For this patch, I used a different version (applied on
> top of 0.23 release) but tried to update it for latest ortp git .
>
> With regards,
> Fred.
>
> This message contains information that may be privileged or confidential and
> is the property of the Capgemini Group. It is intended only for the person to
> whom it is addressed. If you are not the intended recipient, you are not
> authorized to read, print, retain, copy, disseminate, distribute, or use this
> message or any part thereof. If you receive this message in error, please
> notify the sender immediately and delete all copies of this message.
> <0001-Allow-compilation-of-test-programs.patch><0002-Fix-a-warning-in-a-printf-format-of-a-test-program-t.patch><0003-Add-session-information-in-logging-system.patch.xz>_______________________________________________
> Linphone-developers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-developers
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
This message contains information that may be privileged or confidential and is
the property of the Capgemini Group. It is intended only for the person to whom
it is addressed. If you are not the intended recipient, you are not authorized
to read, print, retain, copy, disseminate, distribute, or use this message or
any part thereof. If you receive this message in error, please notify the
sender immediately and delete all copies of this message.