[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 53cb60b1 5/6: Make a class abstract in a diff
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 53cb60b1 5/6: Make a class abstract in a different way |
Date: |
Sat, 16 Jul 2022 11:13:48 -0400 (EDT) |
branch: master
commit 53cb60b1e781581a28bb8199078e58470b83f775
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Make a class abstract in a different way
This replaces the change in commit 10dce09518784 of 20220714T2157Z.
---
datum_sequence.hpp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/datum_sequence.hpp b/datum_sequence.hpp
index 7598d1dd..e122accd 100644
--- a/datum_sequence.hpp
+++ b/datum_sequence.hpp
@@ -59,8 +59,8 @@ class sequence_base
public:
bool equals(sequence_base const&) const;
- virtual bool numeric_values_are_allowable() const;
- virtual bool keyword_values_are_allowable() const;
+ virtual bool numeric_values_are_allowable() const = 0;
+ virtual bool keyword_values_are_allowable() const = 0;
virtual std::string const default_keyword() const;
virtual std::map<std::string,std::string> const allowed_keywords() const;
@@ -72,15 +72,13 @@ class sequence_base
sequence_base(sequence_base&&) = default;
sequence_base& operator=(sequence_base const&) = default;
sequence_base& operator=(sequence_base&&) = default;
- ~sequence_base() override = 0;
+ ~sequence_base() override = default;
sequence_base& operator=(std::string const&);
void assert_sanity() const;
};
-inline sequence_base::~sequence_base() = default;
-
bool operator==(sequence_base const&, sequence_base const&);
// Specialize value_cast<> for each derived class, e.g., as follows:
- [lmi-commits] [lmi] master updated (9effa535 -> a984aa65), Greg Chicares, 2022/07/16
- [lmi-commits] [lmi] master b2c2bea1 2/6: Write certain ctors out of line, Greg Chicares, 2022/07/16
- [lmi-commits] [lmi] master 2aeeb582 4/6: Increase concinnity, Greg Chicares, 2022/07/16
- [lmi-commits] [lmi] master 53cb60b1 5/6: Make a class abstract in a different way,
Greg Chicares <=
- [lmi-commits] [lmi] master a984aa65 6/6: Strengthen sanity preconditions, Greg Chicares, 2022/07/16
- [lmi-commits] [lmi] master 493403d0 1/6: Expunge facility for blocking keywords at run time, Greg Chicares, 2022/07/16
- [lmi-commits] [lmi] master 8c961b81 3/6: Call assert_sanity() iff appropriate, Greg Chicares, 2022/07/16