Re: [lmi] Unused but set variables

[Vadim Zeitlin]

On Mon, 13 Dec 2021 17:34:44 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:

GC> On 12/13/21 4:29 PM, Vadim Zeitlin wrote:
GC> > 
GC> >  After the CI was triggered by a recent commit to master removing
GC> > gui_test.sh, there were two breakages: one was expected, as the script was
GC> > used for running the GUI tests in the MinGW build (what wasn't expected is
GC> > that it's still broken, after replacing the script with the manual
GC> > invocation of wx_test, but this is a different topic),
GC> 
GC> Would you like me to restore 'gui_test.sh'?

 No, I suspected that the failures were not related to the replacement of
the script with the commands that used to be inside it, but since then I've
confirmed that this wasn't the case because I've restored the script in a
branch and the run still failed. Something must have changed in Sid version
of Wine or something, I'll try to investigate, and hopefully fix, this
a.s.a.p. but not today any more.

GC> We plan to upgrade to a debian 'bookworm' chroot for production
GC> in January. Would that be the best time for a wx upgrade?

 It depends on when in January, I believe that I'm close to finishing my wx
changes for high DPI support but I still haven't quite finished them and so
they still won't be finished if it's January 1st. If it's January 31st,
then hopefully yes, but I suspect it will be something closer to the former
rather than the latter?

GC> Or should we ignore this problem for now?

 Yes, it can be ignored and I'll commit a fix disabling the warning in
configure.ac tomorrow.

GC> As above, of course, I'll test that change before pushing it.

 Thanks your change is better (because more extensive, i.e. cleaning up
more unused stuff) than mine.

 Thanks for fixing this so quickly!
VZ

pgpgIskHbwYW2.pgp
Description: PGP signature