[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-401-gdd4ded3

[Joel Cunningham]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  dd4ded3978fe210160add304b21692c47e55c8f3 (commit)
      from  02be2f8f424d148300571fd0155ebbf46db6ddaa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dd4ded3978fe210160add304b21692c47e55c8f3
Author: Joel Cunningham <address@hidden>
Date:   Sat Mar 4 12:29:43 2017 -0600

    do_writemore: fix blocking bug
    
    A bug was introduced in the atomic vector feature for blocking netconns
    where if we couldn't write the entire vector due to send buffer being
    full (write_more is 0), we would not update the vector state and then
    when sent_tcp() is called, it would actually re-send the previous vector
    and if additional calls were required to finish the write, msg.w.offset
    would eventually exceed msg.w.len, This was found by testing "stats"
    from the shell and hitting the LWIP_ASSERT in do_writemore() that
    checks offset < len
    
    The fix simply updates the vector state after every ERR_OK return from
    tcp_write().  While not all cases (non-blocking sockets) need to update
    the state in this case, it keeps the logic simple and also makes
    debugging simpler because you don't have stale vector state at any
    point

-----------------------------------------------------------------------

Summary of changes:
 src/api/api_msg.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack