[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, up
From: |
Sylvain Rochet |
Subject: |
[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-423-ge16d10a |
Date: |
Wed, 8 Mar 2017 16:24:30 -0500 (EST) |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".
The branch, master has been updated
via e16d10ade6204a2f896eb872fb5075bec8e5164f (commit)
from aff1935e409df720e004e6c83d81d50fbc4465d8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e16d10ade6204a2f896eb872fb5075bec8e5164f
Author: Sylvain Rochet <address@hidden>
Date: Wed Mar 8 22:17:40 2017 +0100
PPP: remove unused and confusing return values other than ERR_OK for
ppp_connect and ppp_listen
User should not use ppp_connect or ppp_listen return value to retry
later, it must wait for the callback to be called. This is primarily
done this way to have a consistent behavior with and without the
holdoff feature.
Remove returned error value from PPP link level API connect and listen
callbacks because we are not using them anymore, then make ppp_connect
or ppp_listen to always return ERR_OK, thus we are not breaking the PPP
user API.
We don't need the return code here, all PPP link level drivers can't
fail at all (e.g. PPPoS) or retry if necessary (PPPoE and PPPoL2TP).
-----------------------------------------------------------------------
Summary of changes:
src/include/netif/ppp/ppp_impl.h | 4 ++--
src/netif/ppp/ppp.c | 7 ++++---
src/netif/ppp/pppoe.c | 5 ++---
src/netif/ppp/pppol2tp.c | 5 ++---
src/netif/ppp/pppos.c | 10 ++++------
5 files changed, 14 insertions(+), 17 deletions(-)
hooks/post-receive
--
lwIP - A Lightweight TCPIP stack
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-423-ge16d10a,
Sylvain Rochet <=