[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-973-gde53113

[Joel Cunningham]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  de531131c54103543dcd95aeedfc99a8e95220a0 (commit)
      from  0794d88f09dd8f503b81fe44ea71b92ceb3cf8bc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit de531131c54103543dcd95aeedfc99a8e95220a0
Author: Joel Cunningham <address@hidden>
Date:   Sat Oct 7 21:45:43 2017 -0500

    Fix compiler warnings seen with clang 8.1.0 on MacOS
    
    This fixes the following warnings:
    
    test_tcp.c:266:5: error: code will never be executed 
[-Werror,-Wunreachable-code]
    Â  Â  pbuf_free(p);
    Â  Â  ^~~~~~~~~
     - The check API 'fail' aborts the test, thus pbuf_free(p) will never be 
executed
    
    pbuf.c:783:111: error: format specifies type 'unsigned short' but the 
argument has type 'u8_t' (aka 'unsigned char') [-Werror,-Wformat]
    Â  Â  Â  LWIP_DEBUGF( PBUF_DEBUG | LWIP_DBG_TRACE, ("pbuf_free: %p has ref 
%"U16_F", ending here.\n", (void *)p, ref));
    Â  Â  Â  
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
     - LWIP_PBUF_REF_T is u8_t by default and doesn't match U16_F, so cast to 
u16_t. The cast and formatter will need to be changed
       if ref is larger than 16 bits
    
    ethernet.c:105:16: error: format specifies type 'unsigned char' but the 
argument has type 'unsigned int' [-Werror,-Wformat]
    Â Â  Â  Â  Â  Â  Â  Â  (unsigned)ethhdr->dest.addr[0], 
(unsigned)ethhdr->dest.addr[1], (unsigned)ethhdr->dest.addr[2],
    
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     - addr[] is type u8_t, formatter is X8_F which should be 8 bits. 
'unsigned' is an int, so cast to unsighed char instead

-----------------------------------------------------------------------

Summary of changes:
 src/core/pbuf.c          | 2 +-
 src/netif/ethernet.c     | 8 ++++----
 test/unit/tcp/test_tcp.c | 1 -
 3 files changed, 5 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack