[lwip-users] PPP LCP echo interval u8

[Nikolas Karakotas]

Hi,

 

Is there a reason why the LCP echo data type size is u8?

 

  u8_t  fsm_timeout_time;            /* Timeout time in seconds */

  u8_t  fsm_max_conf_req_transmits;  /* Maximum Configure-Request transmissions */

  u8_t  fsm_max_term_transmits;      /* Maximum Terminate-Request transmissions */

  u8_t  fsm_max_nak_loops;           /* Maximum number of nak loops tolerated */

 

  u8_t  lcp_loopbackfail;     /* Number of times we receive our magic number from the peer

                                 before deciding the link is looped-back. */

  u8_t  lcp_echo_interval;    /* Interval between LCP echo-requests */

  u8_t  lcp_echo_fails;       /* Tolerance to unanswered echo-requests */

 

} ppp_settings;

 

In Iot devices the transmission interval can be high from 5 minutes to an hour + or event driven.

 

Wouldn’t it be more flexible if this was a u16 to allow for a larger echo interval to be set?

 

Nikolas