[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH mediagoblin 1/2] Add db/migrations/env.py to MANIFEST.in
From: |
Ben Sturmfels |
Subject: |
Re: [PATCH mediagoblin 1/2] Add db/migrations/env.py to MANIFEST.in |
Date: |
Mon, 20 Sep 2021 12:10:40 +1000 |
User-agent: |
mu4e 1.6.5; emacs 27.2 |
Hi Elisei,
Thanks very much for the patch! I appreciate you investigating this -
I've never felt I totally understood how the that data_files option
worked in setuptools.
I've merged this into master.
I'm interested to hear more about how you're installing MediaGoblin,
because while we currently recommend people run it out of a git
checkout, I think this should probably change in the future.
Regards,
Ben
On Sun, 19 Sep 2021, ~eroca wrote:
> From: Elisei Roca <eroca@mailbox.org>
>
> This fixes a warning I have with packaging where this file would get
> installed in the wrong place (/usr/mediagoblin/env.py).
> ---
> MANIFEST.in | 1 +
> setup.cfg | 5 -----
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/MANIFEST.in b/MANIFEST.in
> index dd2fd23a..afa295cb 100644
> --- a/MANIFEST.in
> +++ b/MANIFEST.in
> @@ -14,6 +14,7 @@ recursive-include mediagoblin/media_types/video/migrations
> *.py
> include mediagoblin.example.ini mediagoblin/config_spec.ini paste.ini
> include mediagoblin/config_spec.ini
> include mediagoblin/db/migrations/alembic.ini
> +include mediagoblin/db/migrations/env.py
> graft extlib
> graft licenses
> graft devtools
> diff --git a/setup.cfg b/setup.cfg
> index e10eae0b..5bb7083b 100644
> --- a/setup.cfg
> +++ b/setup.cfg
> @@ -92,8 +92,3 @@ zc.buildout =
> make_user_dev_dirs = mediagoblin.buildout_recipes:MakeUserDevDirs
> babel.extractors =
> jinja2 = jinja2.ext:babel_extract
> -
> -[options.data_files]
> -# Running gmg dbupdate fails with missing env.py because env.py isn't
> -# being included in the Python package (no __init__.py).
> -mediagoblin = mediagoblin/db/migrations/env.py