Re: [Nano-devel] [PATCH] Implement incremental search v6

[Marco Diego Aurélio Mesquita]

On Sun, Feb 4, 2018 at 2:04 PM, Benno Schulenberg <address@hidden> wrote:

> True.  The patch that I am about to post should make things easier for
> you -- it gets rid of part of the recursion.
>
> It is not the final version of the patch.  And the whitespace will be
> corrected in a subsequent patch, and two variables renamed, and some
> things reshuffled.  But the basic idea will be clear.  Please inspect
> it, and if you see any problem, please holler.
>

I could not apply your patch but I inspected it. Indeed I think it
makes things much easier for me. Would you mind committing it so I can
rebase my work on top of it?

>> For example, the loop nicely handles the following situation: ^W M-I
>> dam M-W ^R ^C.
>
> To follow your example, run 'src/nano +1 NEWS' and type:
>   ^W  M-I  dam  ^R
> The prompt still shows "[Incremental]".  It shouldn't.
> Type ^R again to return to searching. The screen should jump to the
> first occurrence of "dam" and highlight it, but it stays put at the
> top.
>
> Further things that go wrong.  Run 'src/nano +1 NEWS' and type:
>   ^W  The  M-I
> The first occurrence of "the" does not get highlighted.  It should.
>   <Backspace>  e
> Now it does get highlighted.  Good.
>   M-C
> The screen should jump to the first occurrence of "The", with a
> capital.  But it doesn't.
>   M-B
> The screen should jump to the first occurrence of "The" in the
> backwards direction, from the original starting point.  But it
> doesn't.
>   M-B  <Backspace>  <Backspace>
> The screen should jump back, first to the first occurrence of "Th",
> then to the first occurrence of "T", in the forwards direction from
> the original starting point.  Vim and Emacs jump back when the
> search string is shortened; nano should behave the same way.
>

These seems easier to fix than previous problems. I'll wait for your
patch getting rid of the recursion to land before I fix it.

Thanks.