nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] Future of incremental search


From: Brand Huntsman
Subject: Re: [Nano-devel] Future of incremental search
Date: Sat, 17 Feb 2018 23:11:16 -0700

On Sat, 17 Feb 2018 23:09:57 -0200
Marco Diego Aurélio Mesquita <address@hidden> wrote:

> The attached patch is not intended for inclusion. I'm sending it just
> to make sure it behaves the way it is expected to. It can be applied
> to dd9766c2e025c2df934ae5b8efb934581599e6fd.

Much better, but it has a few issues.

Do a regex search for "+", it says not found but doesn't beep or indicate the 
regex is invalid. Change the "[NOT FOUND]" to "[BAD REGEX]".

I can open the inc-search prompt and press enter to search for previous match 
but that match no longer shows up in the prompt.

The delay you implemented is terrible, it makes search more laggy than before. 
I paste a 90 character line and it takes 2 seconds before the text appears in 
the prompt and gets highlighted, normal search is instant and it only took 
about 1 second in the previous patch. And there is noticeable lag when typing 
in the prompt. I don't know how that wtimeout works but keys need to be drawn 
to the prompt as they are typed. Only the actual incremental search should be 
delayed for 250ms.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]