[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] change warn_and_shortly_pause to an alert
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] change warn_and_shortly_pause to an alert |
Date: |
Tue, 28 Aug 2018 20:05:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Op 27-08-18 om 11:58 schreef Brand Huntsman:
> warn_and_shortly_pause() is used by the following three messages:
>
> "File on disk has changed"
> "No file name"
> "File exists -- cannot overwrite"
>
> The first two open a yesno prompt after the pause. All three would benefit if
> the statusbar message was more visible before exiting or being removed by the
> yesno prompt.
>
Hmm. I thought I had reserved the ALERT thing for real error messages.
But... a file not being writable is not really an error. (Although more
so that "No file name".)
But I agree: those messages would benefit from standing out more.
> - statusbar(msg);
> + statusline(ALERT, msg);
> beep();
ALERT already does a beep, so I have amended your patch to remove it
here. Pushed to master, commit 25e98776.
Thanks.
Benno
signature.asc
Description: OpenPGP digital signature