Re: Fwd: [PATCH 2/3] new feature: "knots" -- a kind of bookmarks, that can be cycled through

[Benno Schulenberg]

Op 05-04-2020 om 16:20 schreef Marco Diego Aurélio Mesquita:
> On my Ubuntu 18.04 with a abnt2-like laptop keyboard pressing alt-' alternate
> between windows of the same app.

Does your keyboard look like this:

 https://en.wikipedia.org/wiki/File:KB_Portuguese_Brazil.svg  ?

When running nano, what is shown when you type:  M-V  M-'  ?

(When I do that here, it shows: ^['.  When I type M-V followed by
Alt+the-key-above-the-Tab-key, it shows: ^[`.  My keyboard is:

  https://en.wikipedia.org/wiki/File:KB_United_States.svg )

>> My implementation doesn't do that.  The third patch then implements a 
>> different behavior: the knot stays near the place where it was placed when a
>> knotted line is deleted.  What do you think of that behavior?
> 
> This is a feature a have been waiting for a long time. I'm willing to accept
> such a compromise to get it accepted.

It has been waiting for such a long time, because you didn't follow through
a year ago.  You stopped sending updates, and I had other things to do.

> When macros were implemented you had the idea, I implemented and you took the
> credits. Now I had the idea, you implemented and I'm just getting and
> "Original-idea-by". Sure, your influence on how macros should be implemented
> was much more detailed than my influence on how bookmarks should work, anyway
> I still don't think it is fair.

Fine.  I will apply your two patches, and afterward change things over to
my implementation.  (Even though for your implementation of bookmarks you
have had extensive guidance -- it went up to V12.)

> But there is more: I actually think my code is more obvious. The jump_to
> function is not a mere "jump to" since it conditionally shows different
> messages.

If you wish, suggest a better name for the function.

> Calling a mark "knot" instead of "bookmark" seems less obvious to me.

"Bookmark" began to sound too permanent to me: when you make a bookmark in a
browser, it is still there when you start the browser the next time.  In nano,
like in Geany, the knot/marker does not get saved and is gone the next time you
start the program.  I would have called the thing a "marker", like in Geany,
but that is too similar to "the mark" that we have in nano.  At first I used
the name "nick", because that is what the ' symbol reminds me of.  If you
like it better, we can use that name.

> My implementation mimics how other similar features are implemented like
> chop_previous_word and chop_next_word that call another function with a
> different argument specifying direction.

I don't care much about similarity between different functions, and less when
they are located in different files.

> I can update my patches to current master and include the changes in your
> "third patch". That is my preferred approach.
> 
> Please give me a go-ahead.

As said, I have already rebased your patch set a week ago (and added a small
improvement that David posted last year).  I'll send those patches in a minute.

Benno

signature.asc
Description: OpenPGP digital signature