[Octave-bug-tracker] [bug #39179] octave_qt_link::do_edit_file always returns true even when QScintilla not present

[Dan Sebald]

URL:
  <http://savannah.gnu.org/bugs/?39179>

                 Summary: octave_qt_link::do_edit_file always returns true
even when QScintilla not present
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Thu 06 Jun 2013 04:16:37 PM GMT
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

Someone submitted a problem to the discussion list about nothing happening
when "edit xxx.m" is typed at the command line.  The issue is that even though
QScintilla was not built for the user's system, octave_qt_link::do_edit_file
() is always returning true so that "edit" script doesn't realize the file was
not opened so that it can act accordingly.

The minimal change should be something like the following:

bool
octave_qt_link::do_edit_file (const std::string& file)
{
#ifdef HAVE_QSCINTILLA
  emit edit_file_signal (QString::fromStdString (file));
  return true;
#else
  return false;
#endif
}

but in the next week or so I will submit a changeset that will add an exchange
of signals whereby this routine emits the signal and then waits to be awaken
with true/false about the success of opening the file.  We'll see how that
behaves and if there is any chance of the system freezing indefinitely we'll
fall back on the above, but it shouldn't be too difficult.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39179>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/