|
From: | Markus Mützel |
Subject: | [Octave-bug-tracker] [bug #51632] make global pkg paths always relative to OCTAVE_HOME, no need to pkg rebuild -global when path changes |
Date: | Sun, 3 Nov 2019 05:29:13 -0500 (EST) |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 |
Follow-up Comment #49, bug #51632 (project octave): The changeset that introduced the short file names in MXE Octave is probably https://hg.octave.org/mxe-octave/rev/a45374f7d9a3 There is no bug number in the commit message. So I don't know which specific error(s) should have been addressed by this change. And I can't test whether this is still necessary. I might not be with the changes to how we use the Windows file system API. Non-ASCII characters are ok now. If it was spaces in paths: they can be an issue on all platforms. But to advance with the original issue: Don't worry about providing cross-builds. I am cross-building quite irregularly but quite frequently myself. Could you please check which of the "canonicalize_file_name" calls can be omitted from your patch? Performance isn't really important for "pkg". But we try to avoid double checks in other places as well. See also comment #41. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?51632> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |