[Octave-bug-tracker] [bug #63162] Inaccurate "Events" location in ode45, ode23(s)

[Ken Marek]

Follow-up Comment #10, bug #63162 (project octave):

Option 1 would let me separate things out into three separable problems: 1)
Events accuracy; 2) Extra function parameters; and 3) Runge-Kutta
interpolation function. They could be three separate patches.

However, each patch would have to modify all the same function definitions and
function calls in all the same files, with some calls happening several times
per file, so it would be maybe 3x the work I have already done, plus (I think)
waiting for each patch to push before the next one goes in, since they all
modify the same lines. Implementing my comment #6 idea (Option 3) would just
mean keeping all my changes so far, plus adding a bit of the same code to each
of ode23/23s/45, which is a lot easier at this point (assuming everything is
as easy as I think, which is never guaranteed). That is why it is my
preference.

To your other comments:
Yes, I think your feval improvements are probably good. I was just trying to
add clarity with the less efficient code, and I wasn't sure that
self-referring to "fcn" in the assignment and feval wouldn't cause a problem,
so I played it safe for the moment.

If I do all the function wrapping in the base odexx file, I'll want to store
funarguments so I don't have to do all the input testing again for Events and
OutputFcn, where they are also used.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63162>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/