octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #63740] GNU Octave launcher 1.0.0.0


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #63740] GNU Octave launcher 1.0.0.0
Date: Sun, 5 Feb 2023 09:21:45 -0500 (EST)

Follow-up Comment #20, bug #63740 (project octave):

I see you bumped the `FILEVERSION` to `1,0,0,1`. In that case, you should also
bump the "FileVersion" field of the "StringFileInfo" block to "1.0.0.1" (to
keep them in sync).

The replacement rules in the patch rely on the version numbering scheme to
stay the same forever. Let's hope that we'll remember adjusting these rules in
case the version numbering scheme of Octave would change at some point in the
future.
But I guess that the "worst-case scenario" would be that the launcher wouldn't
have any valid file properties. (But it would probably still work. So, not
much harm either case.)

Other than the inconsistency in the file version, this looks good to me now.
(But I haven't tested the changes.)



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63740>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]