[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #46451] unable to set breakpoints within class
From: |
Nicholas Jankowski |
Subject: |
[Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes |
Date: |
Tue, 25 Apr 2023 10:56:39 -0400 (EDT) |
Follow-up Comment #29, bug #46451 (project octave):
ok, attached a new complete patch with that last addition.
I attempted to add a placeholder header to this patch file that follows
Octave's code documentation best practices. See
https://wiki.octave.org/Commit_message_guidelines
note that mine is still inadequate. It would help review if you could add a
few lines to each modified file line that summarizes changes made. (note i
also don't properly call out functions as specified in the guidelines, that
could be fixed too).
I also noticed that your test function has some printf echo statements. if
you look at other examples in the test folder, you'll see that each should
contain a .tst script file that will be executed by octaves self test scripts.
These shouldn't echo anything to the console. Notes can be kept internally as
comments if desired.
Would you be able to help make some of these changes and provide a revised
rolled up patch? (the easiest way is to work from a clone not including any of
your changes, apply this patch with the --no-commit option, make any other
changes, then do a single commit with the changes and export it.)
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?46451>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Steve, 2023/04/05
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/05
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, INVALID.NOREPLY, 2023/04/20
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/20
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, INVALID.NOREPLY, 2023/04/21
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/21
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/21
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/21
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/24
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, INVALID.NOREPLY, 2023/04/25
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes,
Nicholas Jankowski <=
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, Nicholas Jankowski, 2023/04/25
- [Octave-bug-tracker] [bug #46451] unable to set breakpoints within classdef classes, INVALID.NOREPLY, 2023/04/26