[Octave-bug-tracker] [bug #64388] audiowrite of mp3s fails

[Markus Mützel]

Update of bug #64388 (project octave):

                  Status:                    None => Ready For Test         
                 Release:                  stable => dev                    
           Fixed Release:                    None => 9.1.0 (current default)
         Planned Release:                    None => 9.1.0 (current default)

    _______________________________________________________

Follow-up Comment #5:

Thanks for your patch.

I understand that the identifiers that are checked in the configure test are
enum values (not preprocessor macros). That means that a configure test is
required. I also understand that we need a new preprocessor macro if we don't
want to impose stricter requirements to the sndfile library that we link to.

Afaict, the requirement for ogg file support in the sndfile library is in
place since at least 2015:
https://hg.savannah.gnu.org/hgweb/octave/rev/3b3579ad7e46
There's probably little point to make it optional now.

Given that, I pushed your patch (with some minor changes) to the default
branch of Octave:
https://hg.savannah.gnu.org/hgweb/octave/rev/9cb43336c3b3

Would it make sense to also add a BIST for that? Maybe, writing a sine to a
.mp3 file and reading it back?

Marking as ready for test.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64388>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/