octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #64555] corr produces input validation error w


From: Nicholas Jankowski
Subject: [Octave-bug-tracker] [bug #64555] corr produces input validation error with two inputs having different number of columns
Date: Thu, 17 Aug 2023 10:49:17 -0400 (EDT)

Update of bug #64555 (project octave):

                  Status:               Confirmed => Ready For Test         
         Planned Release:                    None => 9.1.0 (current default)

    _______________________________________________________

Follow-up Comment #6:

ok, had to stop relying on cov for input validation and put what little of
that there is into corr. handling of row vects and >2d ahead of call to cov
allowed too much past cov's validation. 

pushed fix to default as
http://hg.savannah.gnu.org/hgweb/octave/rev/4f287cb8002c

added an extra check for >2D inputs. added input validations similar to cov.
added tests to verify proper output for inputs with different numbers of
columns and for proper NaN output shape for various inputs, and input
validation tests. noted the 'same number of rows' requirement in the
docstring. also updated cov BISTs that missed some Y checks and fixed varargin
check that was missing logical opt.  passes all tests and a make check against
core octave.

marking ready for test. "eagerly" awaiting more identified corr/cov issues
from package tests.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64555>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]