[Octave-bug-tracker] [bug #64696] Failure to load sparse matrix with no nonzero elements from text file saved by Octave

[Markus Mützel]

Follow-up Comment #4, bug #64696 (project octave):

I wasn't aware that these files are meant to be installed.

In case users are meant to be able to instantiate these templates with more
types, we might need to put some `extern template` declarations somewhere to
avoid that the user code (inadvertently) implicitly instantiates the templates
with the same types for which we'd like to use symbols from liboctinterp.
(That could potentially mess with specializations.)

I haven't checked for all symbols whether there are some which are defined in
the "template declaration file" (e.g., ov-base-diag.cc) or in the header
(e.g., ov-base-diag.h) *and* which are specialized in the "template
instantiation file" (e.g., ov-cx-diag.cc). (I don't know if differing vtables
could be an issue. ISTR to have had some trouble with the Array<T> template
regarding that.)
Anyway, that could be part of another change. And it might not be necessary at
all.

All in all, your change looks good to me. 👍
Imho, it can be pushed to stable.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64696>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/