[Octave-bug-tracker] [bug #64975] Octave for Windows extremely slow

[John W. Eaton]

Follow-up Comment #18, bug#64975 (group octave):

Since there are more functions than clear that use similar pattern matching,
maybe the docstring for each one should just point to a common description of
pattern matching?

We have glob_match defined in liboctave so it seems to me that symbol_match
should be defined there as well.  Maybe it could be defined in the same
liboctave/util/glob-match.{h,cc} files?

In the symbol_match class, maybe m_glob should be a unique_ptr<T> or
shared_ptr<T> object?

It might also be good if the interfaces for glob_match and symbol_match were
the same and they only difference was the method used for matching and
handling of non-ascii symbols.  If I were using these classes and knew nothing
of the history, I'd be surprised to find that copying is allowed for
glob_match objects but not for symbol_match objects.  I might also be
surprised that the type of pattern matching differs on Windows systems, but if
it matters, we could probably fix that later.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64975>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/