[Octave-bug-tracker] [bug #65200] Special nil octave_base_value class to speed up octave_value dtors

[Markus Mützel]

Follow-up Comment #5, bug#65200 (group octave):

I agree that we need better review. I also agree that - if we think the
proposed change is reasonable - the first patch should go to the default
branch. The second patch should go to the bytecode-interpreter branch for the
time being.

Looking at the proposed changes, they look like a reasonable suggestion to me.
We want only one single nilrep instance.
Maybe, we don't want to do any reference counting for that at all?

I haven't quite understood why overloading only the clone function is enough
to achieve something equivalent. Or did I misunderstand the idea behind the
patch?

In any case, we'll probably need to add visibility attributes where
`octave_value_nilrep` is declared in ov.cc, so new types based on
`octave_value` can be defined in .oct files.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65200>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/