[Octave-bug-tracker] [bug #65312] "__run_test_suite__" ran in GUI hangs Octave in some configurations

[Torsten Lilge]

Follow-up Comment #24, bug#65312 (group octave):

This slight extension of Markus' file icon provider (patch on top of Markus'
one) returns folder and file icons from the current icon theme (the latter not
optimal, it is the "document-new" icon).

diff -r 5e6bdf6ad817 libgui/src/files-dock-widget.cc
--- a/libgui/src/files-dock-widget.cc   Wed Feb 14 22:01:08 2024 +0100
+++ b/libgui/src/files-dock-widget.cc   Wed Feb 14 22:31:08 2024 +0100
@@ -182,21 +182,36 @@ class null_file_icon_provider : public Q
 public:
   null_file_icon_provider ()
   {
+    gui_settings settings;
+    file_icon = settings.icon ("document-new");
+    folder_icon = settings.icon ("folder");
     null_icon = QIcon ();
   }
 
-  QIcon icon (IconType) const
+  QIcon icon (IconType ict) const
   {
-    return null_icon;
+    if (ict == QAbstractFileIconProvider::File)
+      return file_icon;
+    else if (ict == QAbstractFileIconProvider::Folder)
+      return folder_icon;
+    else
+      return null_icon;
   }
 
-  QIcon icon (const QFileInfo &) const
+  QIcon icon (const QFileInfo &fi) const
   {
-    return null_icon;
+    if (fi.isFile ())
+      return file_icon;
+    else if (fi.isDir ())
+      return folder_icon;
+    else
+      return null_icon;
   }
 
 private:
   QIcon null_icon;
+  QIcon file_icon;
+  QIcon folder_icon;
 
 };




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65312>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/