[Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry

[Nicholas Jankowski]

Update of bug #65421 (group octave):

                  Status:               Confirmed => Ready For Test         
        Operating System:       Microsoft Windows => Any                    
         Planned Release:                    None => 10.1.0 (current default)

    _______________________________________________________

Follow-up Comment #17:

@lt1234, yes, please create another report that fully describes the crashing
issue.

default built fine and didn't cause any test failures, although it's worth
noting that we have very few plot tests to catch issues.  pushed that patch to
default as: 
https://hg.savannah.gnu.org/hgweb/octave/rev/4ec97d8770ff

So absent any other changes in Octave 10 patch will render even if the user
puts CData before geometric properties. Marking ready for test.


Also pushed a corrected doc description of what the cdata and facevertexcdata
shapes are -supposed- to do, at least according to matlab compatibility and
generally in agreement with what was seen below.  it now reads:


cdata: scalar | matrix | array, def. [](0x0)
Data defining the patch object color relative to its x/y/z-coordinate data.
Patch color can be defined using indices into the current colormap or as RGB
triplets, where the RGB colors are defined along the third dimension. These
colors can be separately defined for the entire patch object, for individual
faces, or for individual vertices, and is determined by the shape of "cdata"
as follows:

If "cdata" is a scalar index into the current colormap or a 1-by-1-by-3 RGB
triplet, it defines the color of all faces and edges.

If the patch object has N faces, and "cdata" is a 1-by-N vector of colormap
indices or a 1-by-N-by-3 RGB array, it defines the color of each face.

If the patch object has N faces and M vertices per face, and cdata is a M-by-N
matrix of colormap indices or a M-by-N-by-3 RGB array, it defines the color at
each vertex. (The shape of "cdata" should match that of "xdata", "ydata", and
"zdata".)

...

facevertexcdata: scalar | matrix, def. [](0x0)
Data defining the patch object color relative to its face-vertex data. Patch
color can be defined using indices into the current colormap or as RGB
triplets, where the RGB colors are defined in the rows of "facevertexcdata".
These colors can be separately defined for the entire patch object, for
individual faces, or for individual vertices, and is determined by the shape
of "facevertexcdata" as follows:
 
If facevertexcdata is a scalar index into the current colormap or a 1-by-3 RGB
triplet, it defines the color of all faces and edges.

If the patch object has N faces, and facevertexcdata is a N-by-1 column vector
of indices or a N-by-3 RGB matrix, it defines the color of each one of the N
faces.

If the patch object has M vertices, and facevertexcdata is a M-by-1 column
vector of indices or a M-by-3 RGB matrix, it defines the color at each vertex.



pushed to stable as https://hg.savannah.gnu.org/hgweb/octave/rev/0e2fbef78702


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65421>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/