[Octave-patch-tracker] [patch #10314] matlab compatible std, var, mean, median to core from statistics package

[Nicholas Jankowski]

URL:
  <https://savannah.gnu.org/patch/?10314>

                 Summary: matlab compatible std, var, mean, median to core
from statistics package
                 Project: GNU Octave
               Submitter: nrjank
               Submitted: Tue 14 Feb 2023 05:24:53 PM EST
                Category: Core : new feature
                Priority: 5 - Normal
                  Status: In Progress
                 Privacy: Public
             Assigned to: nrjank
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 14 Feb 2023 05:24:53 PM EST By: Nicholas Jankowski <nrjank>
There are a number of separate bug reports that address pieces of bringing the
functions named above up to full matlab compatibility.  primary concerns are:
- proper empty input handling 
- compatible vector dimension handling
- "all" dimension option handling
- nanflag handling (option to ignore nan values)
- compatible outtype handling

The statistics package has shadowed these functions for octave core and very
recently all four functions were made fully matlab compatible.  mean had been
ported from statistics to core previously, but compatibility was still
incomplete and there was forked development.

I've worked with the statistics package to bring the functions into a
compatible state, including avoiding any mean regressions, and the plan is now
to merge those changes back into core octave.  Moving forward then statistics
can just incorporate any changes to core and shadow them for older versions of
octave (targeting v9.1)

In addition, these versions of mean and median should solve bug #54567
regarding large int overflow and double precision limits. 

The functions need some header and other text rework to match core function
style.  Once I do that cleanup I'll attach those versions to this report and
push a patch for review after i verify they don't seriously break any calling
functions in core. I'll also try to go through the pile of related bug reports
and update/close/dependency-mark them accordingly.

Note: i've done some optimization and speed testing, but the extra input
handling for the functions does add overhead. some advice on refactoring to
buy back some of that performance would be appreciated. 









    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10314>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/