[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #10316] Add Resolution and ResolutionUnit
From: |
anonymous |
Subject: |
[Octave-patch-tracker] [patch #10316] Add Resolution and ResolutionUnit parameters to imwrite. |
Date: |
Sun, 19 Feb 2023 00:53:42 -0500 (EST) |
Follow-up Comment #1, patch #10316 (project octave):
I just noticed that imfinfo returns the resolution in the struct as
XResolution and YResolution; rather than as a single Resolution vector. Let me
know if I should adjust my patch to use separate XResolution and YResolution
params on this basis -- although I think I prefer the way it currently is (the
MATLAB behaviour of saying YResolution will be the same as XResolution unless
specifically overridden seems messy to me; it's non-obvious what happens if
only "XResolution" is set without checking the documentation.)
Also, would it make sense for me to add tests to imwrite.m that write the file
out with custom resolution settings, and then validate that they have been
correctly set by reading them back in with imfinfo?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/patch/?10316>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/