octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10236] interpreter: Constant literal type


From: Arun Giridhar
Subject: [Octave-patch-tracker] [patch #10236] interpreter: Constant literal type_id
Date: Tue, 28 Feb 2023 06:53:46 -0500 (EST)

Follow-up Comment #1, patch #10236 (project octave):

I tried updating this patch but got a long series of compiler errors. I could
not clear it up for two reasons:

* There was a recent activity to rename static variables foo as s_foo. Are
names like s_t_name and s_c_name intended to be static or just string? This
breaks some of the macro expansions in the patch.

* There was also a recent maintenance activity (by me actually) to remove dead
code that had been commented out by "#if 0" for years. These included many
lines in Range for types other than double. Many of the lines in this patch
make similar changes in Range. But it doesn't compile with or without those
lines. It's not clear whether the patch intended such definitions to become
active or not.

Pls see if you can take a look at the intent behind the code and the patch for
the above points.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10236>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]