[Octave-patch-tracker] [patch #10218] interpreter: Avoid string construction 3

[John W. Eaton]

Update of patch #10218 (project octave):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #2:

I see now that this patch is also the file avoidstringctors_3.patch attached
to patch #10147.  There, I added the comment

I agree that setting retval = "" (the first part of the diff) is unnecessary,
but setting dir_name = "" in the other two bits of the diff ensures that
dir_name is empty if no valid function is found.  That seems reasonable to me,
as the user of the function might have passed something else and setting it to
"" could avoid later confusion.  I understand these are "internal" functions
and that maybe fcn_info "is not supposed to be used that way" but I tend to
worry about future maintenance.

I pushed this change:

http://hg.savannah.gnu.org/hgweb/octave/rev/359de694adce

Closing report.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10218>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/