Re: [phpGroupWare-developers] line lengths

[Chris Weiss]

On Wed, Apr 30, 2008 at 4:58 PM, Sigurd Nes <address@hidden> wrote:
> Chris Weiss wrote:
>  > On Wed, Apr 30, 2008 at 3:28 PM, Dave Hall <address@hidden> wrote:
>  >> On Wed, 2008-04-30 at 08:43 -0500, Chris Weiss wrote:
>  >>  > On Wed, Apr 30, 2008 at 1:31 AM, Dave Hall <address@hidden> wrote:
>  >>  > >  Yes, but also very long lines can indicate inelegant solutions.
>  >>  >
>  >>  > php is an inelegant solution.  more elegant than Basic though, where
>  >>  > splitting up line is just plain tedious and limiting
>  >>  >
>  >>  > And just because it can be, doesn't mean it is, thus a target with no
>  >>  > hard limit.
>  >>
>  >>  Compromise is warn at 100 with no error?
>  >>
>  >>
>  >
>  > yes, but i think Sigurd's point is that the number of warning and
>  > errors caused by line length may be overwelming.  would be interesting
>  > to see the difference
>  >
>
>  Recursive test for lengths on phpgwapi gives:
>  A TOTAL OF 17248 ERROR(S) AND 7627 WARNING(S) WERE FOUND IN 477 FILE(S)
>
>  Errors being at length 100.
>

so warning at 80 and errors at 100, line length check only?

unless we want to make this for new code only, I don't think we should
be worrying about it at this time