[Phpgroupware-tracker] [patch #2916] Accounts <-> Contact link fix

[Philipp Kamps]

This mail is an automated notification from the patch tracker
 of the project: phpGroupWare.

/**************************************************************************/
[patch #2916] Latest Modifications:

Changes by: 
                Philipp Kamps <address@hidden>
'Date: 
                Wed 05/05/04 at 13:59 (GMT)

------------------ Additional Follow-up Comments ----------------------------
so boys and girls,

this one was tricky - but i got it finally:

- the creation of the contact for the account was in class.accounts.inc.php. I 
moved this logic to the admin module; so it is working with ldap as well. Some 
superfluous code could be removed therefore.

- class.accounts_ldap.inc.php know saves the person_id of this new contact in 
ldap. I added the phpgwcontact objectclass to the ldap entry; it has the field 
phpgwcontactid which is been used to store the value.

- i discovered that the phpgwcontact objectclass is structural and not 
auxiliary. This isn't good at all and i'll have to change the schema file for 
HEAD.

- i disabled the account<->contacts sync thing in the admin interface (ONLY for 
LDAP). It doesn't do anything usefull right now.

- if you have time, plz test the patch and give me some feedback.

Thanks, fips







/**************************************************************************/
[patch #2916] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=2916>
Project: phpGroupWare
Submitted by: Dave Hall
On: Thu 04/08/04 at 03:29

Category:  API -  phpGWapi
Priority:  9 - Immediate
Resolution:  None
Assigned to:  skwashd
Originator Email:  
Status:  Open


Summary:  Accounts <-> Contact link fix

Original Submission:  Hi

I have found that when the new ldap schema was done, the accounts<->contacts 
link was removed.  This patch is an attempt to fix it.

I know you can't apply it, I just hope you can tell me if it is ok.

Cheers

Follow-up Comments
------------------


-------------------------------------------------------
Date: Wed 05/05/04 at 13:59         By: fipsfuchs
so boys and girls,

this one was tricky - but i got it finally:

- the creation of the contact for the account was in class.accounts.inc.php. I 
moved this logic to the admin module; so it is working with ldap as well. Some 
superfluous code could be removed therefore.

- class.accounts_ldap.inc.php know saves the person_id of this new contact in 
ldap. I added the phpgwcontact objectclass to the ldap entry; it has the field 
phpgwcontactid which is been used to store the value.

- i discovered that the phpgwcontact objectclass is structural and not 
auxiliary. This isn't good at all and i'll have to change the schema file for 
HEAD.

- i disabled the account<->contacts sync thing in the admin interface (ONLY for 
LDAP). It doesn't do anything usefull right now.

- if you have time, plz test the patch and give me some feedback.

Thanks, fips


-------------------------------------------------------
Date: Sat 05/01/04 at 10:00         By: skwashd
This doesn't work :(




CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
charlesk --AT-- generalpants --DOT-- com --DOT-- au | 
jarg                                | 
benoit --DOT-- hamet --AT-- int-evry --DOT-- fr | FYI



File Attachments
-------------------

-------------------------------------------------------
Date: Wed 05/05/04 at 13:59  Name: phpgwapi-inc.patch  Size: 10KB   By: 
fipsfuchs

http://savannah.gnu.org/patch/download.php?item_id=2916&amp;item_file_id=3204

-------------------------------------------------------
Date: Wed 05/05/04 at 13:49  Name: admin.patch  Size: 1KB   By: fipsfuchs

http://savannah.gnu.org/patch/download.php?item_id=2916&amp;item_file_id=3203






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=2916>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/