[Phpgroupware-tracker] [bugs #8541] SQL Error in rightmost chat frame (suggested fix listed)

[Dave Hall]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #8541] Latest Modifications:

Changes by: 
                Dave Hall <address@hidden>
'Date: 
                Tue 05/11/04 at 04:58 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
         Assigned to | None                      | skeeter
              Status | Open                      | Closed







/**************************************************************************/
[bugs #8541] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=8541>
Project: phpGroupWare
Submitted by: 0
On: Mon 04/12/04 at 14:26

Category:  chat
Item Group:  0.9.16.000 release
Severity:  5 - Average
Priority:  7 - High
Resolution:  Fixed
Assigned to:  skeeter
Status:  Closed
Component Version:  TGZ
Platform Version:  GNU/Linux - RedHat/Fedora
Reproducibility:  Every Time


Summary:  SQL Error in rightmost chat frame (suggested fix listed)

Original Submission:  Using:
MySQL Server Version:  3.23.58
PHP Version 4.3.4

The rightmost frame produces an SQL error resulting from a syntax error on line 
186 of .../class.sessions_db.inc.php'.  I suspect this problem is SQL version 
specific - my particular version doesn't find ordering ASC before session_lid 
to be palatable.  After some experimenting, I have found that switching '$sort' 
and '$order' on line 186 fixed the problem.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 05/10/04 at 15:45         By: None
I also found this bug and applied and investigated this fix (before I found 
this bug report). I'm not an SQL guru but I tried the syntax of the error and 
found it incorrect. The correct syntax is:- SELECT * FROM phpgw_sessions limit 
WHERE session_flags != 'A' ORDER BY session_lid ASC
Which in the code I believe is "select * from phpgw_sessions where 
session_flags != 'A' order by $order $sort"
Perhaps the confusion is in the variable names. I would have had the ASC being 
the "order" not the "sort".
Either way, when I fixed it, it did not break the admin.                        
                     

-------------------------------------------------------
Date: Mon 04/12/04 at 15:50         By: None
It turns out that the "fix" I listed above breaks session administration (and 
who knows what else), so I changed it back.  Any other suggestions on how to 
get this working properly???

<<<Brian












For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=8541>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/