[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Phpgroupware-tracker] [bugs #10482] Deleteing User in LDAP won't remove
From: |
Philipp Kamps |
Subject: |
[Phpgroupware-tracker] [bugs #10482] Deleteing User in LDAP won't remove it from its groups |
Date: |
Fri, 01 Oct 2004 10:14:44 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040924 Debian/1.7.3-2 |
This mail is an automated notification from the bugs tracker
of the project: phpGroupWare.
/**************************************************************************/
[bugs #10482] Latest Modifications:
Changes by:
Philipp Kamps <address@hidden>
'Date:
Fri 10/01/04 at 14:05 (GMT)
------------------ Additional Follow-up Comments ----------------------------
hi caeies,
patch is great.
some little modifications - just some tiny remarks - don't take them too
serious and add them only if you really want:
- I dont understand this comment: "//get the groups this dn in it's own groups"
- "if (($olddn=$oldEntry['dn']) != $dn)" no need to declare $olddn - you only
need this var once some lines below.
- "$groups = $this->membership($account_info['account_id']);" instead of using
$account_info['account_id'] can we use a value from the $oldEntry array?
- plz add method description for "function getUIDfromDN($dn)"
- in case you have a group with just one member - are you sure that this member
can be deleted? The program logic is in this if statement:
"if (is_array($groupEntry['memberuid']))"
As I said before - these remarks are kids stuff - if you want me to change the
patch Im happy to do it.
Otherwise I think it is a clean and nice implementation for this feature.
/**************************************************************************/
[bugs #10482] Full Item Snapshot:
URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=10482>
Project: phpGroupWare
Submitted by: Olivier Berger
On: Thu 09/23/04 at 15:59
Item Group: 0.9.16.003
Category: API - Admin
Severity: 5 - Average
Priority: 5 - Normal
Resolution: None
Privacy: Public
Assigned to: fipsfuchs
Status: Open
Component Version: CVS
Platform Version: GNU/Linux - Debian
Reproducibility: Every Time
Planned Release: None
Fixed Release:
Summary: Deleteing User in LDAP won't remove it from its groups
Original Submission: When using LDAP to store users and groups, the user
deletion in admin/user won't remove the User from its groups : user gets
deleted in LDAP but the group's memberUid is still there in the Group in LDAP.
Follow-up Comments
------------------
-------------------------------------------------------
Date: Fri 10/01/04 at 14:05 By: Philipp Kamps <fipsfuchs>
hi caeies,
patch is great.
some little modifications - just some tiny remarks - don't take them too
serious and add them only if you really want:
- I dont understand this comment: "//get the groups this dn in it's own groups"
- "if (($olddn=$oldEntry['dn']) != $dn)" no need to declare $olddn - you only
need this var once some lines below.
- "$groups = $this->membership($account_info['account_id']);" instead of using
$account_info['account_id'] can we use a value from the $oldEntry array?
- plz add method description for "function getUIDfromDN($dn)"
- in case you have a group with just one member - are you sure that this member
can be deleted? The program logic is in this if statement:
"if (is_array($groupEntry['memberuid']))"
As I said before - these remarks are kids stuff - if you want me to change the
patch Im happy to do it.
Otherwise I think it is a clean and nice implementation for this feature.
-------------------------------------------------------
Date: Fri 09/24/04 at 15:02 By: Caeies <Caeies>
The new patch here, seems to be ok for both deleting accounts (and removing
menmberUID) and modifying the dn of an account.
I think that we perhaps need to check against other kings of memberUID, but
that's our default schema I guess.
my 2Cts,
Any comment on this is welcome.
Regards,
Caeies
-------------------------------------------------------
Date: Fri 09/24/04 at 11:40 By: Caeies <Caeies>
Ok, In fact this is not the real problem,
I guess that we need to define a way that is both SQL and LDAP working for
changing the login id ...
We need to take care of some oddies on LDAP, as I said in my last mail.
Regards,
Caeies
-------------------------------------------------------
Date: Fri 09/24/04 at 08:51 By: Caeies <Caeies>
Hum, I found a nasty problem when renaming dn ... the function id2name use a
cache system which is not updated when modifying the dn, this kill the
add_account2Group and delete_account4Group, ...
No idea on how to correct this properly ...
I think we have the choice btw, modyfing add_account2Group/delete_account4Group
to take the lid and not the id and then don't do an id2name call
or try to unset the cache when modifying the dn ... which I guess is the most
preferable way to do it ...
Regards,
Caeies
-------------------------------------------------------
Date: Fri 09/24/04 at 07:29 By: Philipp Kamps <fipsfuchs>
please don't have a deeper look to the rest of the API. You won't be able to
sleep anymore ;-)
You're right: A rename of the account changes the dn but
don't update memberUid. But I don't see other kind of things
we have to investigate.
-------------------------------------------------------
Date: Fri 09/24/04 at 07:12 By: Caeies <Caeies>
By the way, I didn't sleep well this night, and think about this bug.
We forgot at least in an other place to do this kind of thing :
When you change the dn, you need to update the memberUid in LDAP to, for each
groups this dn is a member ...
Will try to put a patch for this too.
regards,
Caeies.
-------------------------------------------------------
Date: Thu 09/23/04 at 17:51 By: Philipp Kamps <fipsfuchs>
I'll have a look tomorrow and give you feedback - thanks for asking me.
-------------------------------------------------------
Date: Thu 09/23/04 at 16:05 By: Caeies <Caeies>
Bug acknowledged
Fips, could you take a look at this ?
Thanks,
Caeies
File Attachments
-------------------
-------------------------------------------------------
Date: Fri 09/24/04 at 15:02 Name: patch_manage_groups_ldap.patch Size: 3.5KB
By: Caeies
New suggested patch
http://savannah.gnu.org/bugs/download.php?item_id=10482&item_file_id=1704
-------------------------------------------------------
Date: Thu 09/23/04 at 16:05 Name: patch_delete_account_ldap.diff Size: 724B
By: Caeies
Suggested correction
http://savannah.gnu.org/bugs/download.php?item_id=10482&item_file_id=1697
For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=10482>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Phpgroupware-tracker] [bugs #10482] Deleteing User in LDAP won't remove it from its groups,
Philipp Kamps <=