poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: provide %c and %u8c formatting in pickle printf()


From: Henner Zeller
Subject: Re: PATCH: provide %c and %u8c formatting in pickle printf()
Date: Sun, 29 Sep 2019 08:11:26 -0700

Errata: Some terminals that do understand UTF-8 might not be happy
with characters >= 0x7f, so instead of

pk-dump.pk:86:
if (v < ' ')
this should probably be
if (v < ' ' || v > '~')

(I would've expected that if (v < ' ' || v > 0x7f) should work, but it
does not and I don't know pickle enough yet to understand why)

-h
On Sun, 29 Sep 2019 at 07:09, Henner Zeller <address@hidden> wrote:
>
> Hi,
> Not sure if this is the best way to implement this (I have not
> entirely grokked the whole jitter thing yet), but at least it could be
> a suggestion.
>
> Here is a little patch that adds %c (which is also understood as %u8c)
> formatting in printf().
>
> With that, the ascii printing in pk-dump.pk could be implemented.
>
> So commit message maybe
>   o Add %c formatting in printf()
>   o Add more detailed error messages in format string problems
>   o implement ascii printing for the dump command (pk-dump.pk)
>
> Cheers,
>   Henner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]