Re: [PATCH] libpoke: Use uncollectable memory instead of GC roots

[Mohammad-Reza Nabipoor]

Hi, Jose!

On Thu, Apr 22, 2021 at 10:40:51AM +0200, Jose E. Marchesi wrote:
> 
> I like this solution.  We are effectively using the reference-counting
> schema of the AST to allocate/free these fields, like the rest of the
> node contents.  Very good.
> 
> I wasn't aware of the fact that GC_malloc_uncollectable effectively
> adds a GC root... hopefully there is not a limit of objects allocated
> this way?  Because in that case we would be in exactly the same problem
> than before :)
> 
> If there isn't any limit, then this is OK for both master and
> maint/poke-1.
> 


It seems there isn't any limit.
Pushed to master and maint/poke-1.


> I assume this fix is fixing the hard-limit you was finding while loading
> pickles?
> 


The problem was with `testsuite/poke.mi-json/mi-json`, due to hard-limit
of number of GC roots, we couldn't add new sample JSON files.
This commit fixes that issue.
And also this is useful for `format` (because of formater closure).


Thanks,
Mohammad-Reza